Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] POS cfe xml export at fiscal closing #152

Open
wants to merge 5 commits into
base: 14.0-mig-l10n_br_pos
Choose a base branch
from
Open

[ADD] POS cfe xml export at fiscal closing #152

wants to merge 5 commits into from

Conversation

lfdivino
Copy link
Member

@lfdivino lfdivino commented Feb 6, 2023

No description provided.

@lfdivino lfdivino force-pushed the 14.0-mig-l10n_br_pos_cfe_export_xml branch from 3225214 to 93a6f8a Compare February 9, 2023 18:11
ygcarvalh
ygcarvalh approved these changes Feb 13, 2023
View reviewed changes
Copy link

@ygcarvalh ygcarvalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2023 •
edited
Loading

Codecov Report

Merging #152 (93a6f8a) into 14.0-mig-l10n_br_pos (e2082a8) will increase coverage by 0.89%.
Report is 698 commits behind head on 14.0-mig-l10n_br_pos.
The diff coverage is 85.74%.

❗ Current head 93a6f8a differs from pull request most recent head 0f45d2a. Consider uploading reports for the commit 0f45d2a to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                   Coverage Diff                    @@
##           14.0-mig-l10n_br_pos     #152      +/-   ##
========================================================
+ Coverage                 85.22%   86.11%   +0.89%     
========================================================
  Files                       506      546      +40     
  Lines                     18148    20105    +1957     
  Branches                   2292     2514     +222     
========================================================
+ Hits                      15466    17313    +1847     
- Misses                     1968     2016      +48     
- Partials                    714      776      +62
Files Changed Coverage Δ
l10n_br_fiscal/models/data_ncm_nbs_abstract.py 72.50% <0.00%> (+33.75%) ⬆️
l10n_br_fiscal/models/document_eletronic.py 70.27% <ø> (ø)
l10n_br_fiscal/models/icms_regulation.py 82.30% <0.00%> (ø)
l10n_br_fiscal/models/operation.py 74.19% <0.00%> (ø)
l10n_br_fiscal/models/operation_line.py 81.44% <0.00%> (ø)
l10n_br_nfe_spec/models/spec_models.py 100.00% <ø> (ø)
l10n_br_nfse/models/document.py 66.11% <ø> (+0.76%) ⬆️
l10n_br_pos/models/__init__.py 100.00% <ø> (ø)
l10n_br_pos/models/cfop.py 100.00% <ø> (ø)
l10n_br_pos/models/document_related.py 66.66% <ø> (ø)
... and 92 more

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luismalta luismalta luismalta approved these changes

@ygcarvalh ygcarvalh ygcarvalh approved these changes

@mileo mileo Awaiting requested review from mileo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lfdivino @codecov-commenter @luismalta @ygcarvalh